feat: added LayerHitTestStrategy to feature layers
#2050
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated example app
Member
Author
|
I honestly can't decide myself whether this feature is necessary. I thought I could think of a use-case for it, but I can't particularly (that MapOptions.onTap wouldn't already). Happy to close if you think it's not useful, lmk. |
Contributor
|
@JaffaKetchup I'm not sure it still makes sense to keep that PR as we moved the "inverted" feature from polygon holes to polygon layers. |
Member
Author
|
I think I'm going to close this then. Maybe the ability to not consider non-interactive polygons as hittable could be useful, but that can be more easily/better implemented at some other point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I honestly can't decide myself whether this feature is necessary. I thought I could think of a use-case for it, but I can't particularly (that
MapOptions.onTapwouldn't already). Happy to close if you think it's not useful, lmk.This is designed to go well in conjunction with #2046, which will allow for the painting of inverted polygons.
It adds more options to control hitting.
Non-polygon page hasn't been updated in example app, although the new features do apply to all the layers.